Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate address & pk #684

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: validate address & pk #684

merged 1 commit into from
Feb 12, 2025

Conversation

0xDazzer
Copy link
Contributor

@0xDazzer 0xDazzer commented Feb 10, 2025 •
edited
Loading

Closes: #571

jrwbabylonlab
jrwbabylonlab approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ensure test this locally before merging.
After merged, could u please ping devops to release this to staging before moving to mainnet?

@0xDazzer
Copy link
Contributor Author

0xDazzer commented Feb 11, 2025 •
edited
Loading

@gbarkhatov @jeremy-babylonlabs can you help and test it locally?

jeremy-babylonlabs
jeremy-babylonlabs approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@jeremy-babylonlabs jeremy-babylonlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xDazzer 0xDazzer merged commit f47a65d into v0.3.x Feb 12, 2025
4 checks passed
@0xDazzer 0xDazzer deleted the validate-address-pk branch February 12, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@jeremy-babylonlabs jeremy-babylonlabs jeremy-babylonlabs approved these changes

@gbarkhatov gbarkhatov Awaiting requested review from gbarkhatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xDazzer @jrwbabylonlab @jeremy-babylonlabs