feat: add Babylon Finality Gadget For OP Stack #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGO is disabled but some dependencies added by the finality gadget require CGO
feat: finality gadget client
chore: add mockgen cmd + clarify dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
context: ethereum-optimism/specs#218
an L2 block has 3 status:
now we are changing it to
After studying the OP codebase, we think the only place we need to change is in the
EngineQueue::Step()functionIt's worth noting we don't need to worry about
EngineQueue::Reset()wheresync.FindL2Heads()is called. Digging into the code, this calls intoop-gethto get the current L2 forkchoice state including the finalized head. Since the data there was also from the derivation pipeline, it should return the correct block.