fix mocks

clientcontroller/babylon.go

@@ -3,7 +3,6 @@ package clientcontroller
 import (
 	"context"
 	"fmt"
-	coretypes "github.com/cometbft/cometbft/rpc/core/types"
 	"strings"
 	"time"
 
@@ -416,8 +415,13 @@ func (bc *BabylonController) QueryBestBlock() (*types.BlockInfo, error) {
 	return blocks[0], nil
 }
 
-func (bc *BabylonController) NodeStatus() (*coretypes.ResultStatus, error) {
-	return bc.bbnClient.GetStatus()
+func (bc *BabylonController) NodeTxIndexEnabled() (bool, error) {
+	res, err := bc.bbnClient.GetStatus()
+	if err != nil {
+		return false, fmt.Errorf("failed to query node status: %w", err)
+	}
+
+	return res.TxIndexEnabled(), nil
 }
 
 func (bc *BabylonController) queryCometBestBlock() (*types.BlockInfo, error) {

clientcontroller/interface.go

@@ -1,10 +1,8 @@
 package clientcontroller
 
 import (
-	"fmt"
-	coretypes "github.com/cometbft/cometbft/rpc/core/types"
-
 	"cosmossdk.io/math"
+	"fmt"
 	btcstakingtypes "github.com/babylonlabs-io/babylon/x/btcstaking/types"
 	"github.com/btcsuite/btcd/btcec/v2"
 	"github.com/btcsuite/btcd/btcec/v2/schnorr"
@@ -90,7 +88,7 @@ type ClientController interface {
 	// the value zero should be returned.
 	QueryFinalityActivationBlockHeight() (uint64, error)
 
-	NodeStatus() (*coretypes.ResultStatus, error)
+	NodeTxIndexEnabled() (bool, error)
 
 	Close() error
 }

finality-provider/service/app_test.go

@@ -69,6 +69,7 @@ func FuzzCreateFinalityProvider(f *testing.F) {
 		mockClientController.EXPECT().QueryFinalityProvider(gomock.Any()).Return(nil, nil).AnyTimes()
 		mockClientController.EXPECT().QueryBlocks(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, nil).AnyTimes()
 		mockClientController.EXPECT().QueryLastCommittedPublicRand(gomock.Any(), uint64(1)).Return(nil, nil).AnyTimes()
+		mockClientController.EXPECT().NodeTxIndexEnabled().Return(true, nil).AnyTimes()
 
 		// Create randomized config
 		fpHomeDir := filepath.Join(t.TempDir(), "fp-home")
@@ -222,6 +223,7 @@ func FuzzUnjailFinalityProvider(f *testing.F) {
 		mockClientController.EXPECT().QueryLatestFinalizedBlocks(gomock.Any()).Return(nil, nil).AnyTimes()
 		mockClientController.EXPECT().QueryBestBlock().Return(blkInfo, nil).Return(blkInfo, nil).AnyTimes()
 		mockClientController.EXPECT().QueryBlocks(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil, errors.New("chain not online")).AnyTimes()
+		mockClientController.EXPECT().NodeTxIndexEnabled().Return(true, nil).AnyTimes()
 
 		// set voting power to be positive so that the fp should eventually become ACTIVE
 		mockClientController.EXPECT().QueryFinalityProviderVotingPower(gomock.Any(), gomock.Any()).Return(uint64(0), nil).AnyTimes()

finality-provider/service/fp_instance.go

@@ -1041,12 +1041,12 @@ func (fp *FinalityProviderInstance) GetFinalityProviderSlashedOrJailedWithRetry(
 }
 
 func (fp *FinalityProviderInstance) txIndexEnabled() error {
-	res, err := fp.cc.NodeStatus()
+	enabled, err := fp.cc.NodeTxIndexEnabled()
 	if err != nil {
 		return fmt.Errorf("failed to query node status: %w", err)
 	}
 
-	if !res.TxIndexEnabled() {
+	if !enabled {
 		return fmt.Errorf("tx indexing in the babylon node must be enabled")
 	}