Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command to generate pop #111

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Conversation

KonradStaniec
Copy link
Collaborator

@KonradStaniec KonradStaniec commented Dec 23, 2024

Inttroduces command to create PoP between phase-1 and phase-2

@KonradStaniec KonradStaniec marked this pull request as ready for review January 7, 2025 12:13
Comment on lines 167 to 182
func parseNetwork(n string) (*chaincfg.Params, error) {
switch n {
case "mainnet":
return &chaincfg.MainNetParams, nil
case "testnet3":
return &chaincfg.TestNet3Params, nil
case "regtest":
return &chaincfg.RegressionNetParams, nil
case "simnet":
return &chaincfg.SimNetParams, nil
case "signet":
return &chaincfg.SigNetParams, nil
default:
return nil, fmt.Errorf("unknown network: %s", n)
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use GetBtcNetworkParams

func GetBtcNetworkParams(network string) (*chaincfg.Params, error) {

Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@KonradStaniec KonradStaniec merged commit 0a59e30 into main Jan 8, 2025
12 checks passed
@KonradStaniec KonradStaniec deleted the konradstaniec/generate-pop-btc branch January 8, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants