fix: e2e rewards test flaky #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tryfix-flunky-e2e-rwd
…tryfix-flunky-e2e-rwd
… auto flag from e2e txs
RafilxTenfen
requested review from
gitferry,
SebastianElvis and
KonradStaniec
RafilxTenfen
changed the title
RafilxTenfen
commented
Jan 31, 2025
| @@ -50,6 +50,10 @@ func CheckTxFeeWithGlobalMinGasPrices(ctx sdk.Context, tx sdk.Tx) (sdk.Coins, in | |||
| // provided in a transaction. | |||
| // NOTE: This implementation should not be used for txs with multiple coins. | |||
| func getTxPriority(fee sdk.Coins, gas int64) int64 { | |||
| if gas == 0 { | |||
There was a problem hiding this comment.
it would panic to quote as zero
RafilxTenfen
commented
Jan 31, 2025
| n1.WaitUntilCurrentEpochIsSealedAndFinalized(1) | ||
| // needs to wait for a block to make sure the pub rand is committed | ||
| // prior to epoch finalization | ||
| n2.WaitForNextBlockWithSleep50ms() |
There was a problem hiding this comment.
important part, before the pub rand might not get included in the latest epoch and then it would not be finalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass 1 https://github.com/babylonlabs-io/babylon/actions/runs/13081416537/job/36505723250
Pass 2 https://github.com/babylonlabs-io/babylon/actions/runs/13081416537/job/36506484641
Pass 3 https://github.com/babylonlabs-io/babylon/actions/runs/13081416537/job/36506854617
Pass 4 https://github.com/babylonlabs-io/babylon/actions/runs/13081416537/job/36507342272
Pass 5 https://github.com/babylonlabs-io/babylon/actions/runs/13081416537/job/36508176401