Konradstaniec/add sending tx to replay tests #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
added
the
A:no-changelog
KonradStaniec
requested review from
gitferry and
Lazar955
and removed request for
a team
Lazar955
reviewed
Dec 11, 2024
test/replay/app_replay_e2e_test.go
Outdated
| @@ -478,3 +648,41 @@ func TestReplayBlocks(t *testing.T) { | |||
| require.Equal(t, driver.LastState.LastBlockHeight, replayer.LastState.LastBlockHeight) | |||
| require.Equal(t, driver.LastState.AppHash, replayer.LastState.AppHash) | |||
| } | |||
|
|
|||
| func TestSendingTxFromDriverAccount(t *testing.T) { | |||
| driverTempDir, err := os.MkdirTemp("", "test-app-event") | |||
There was a problem hiding this comment.
Suggested change
| driverTempDir, err := os.MkdirTemp("", "test-app-event") | |
| driverTempDir := t.TempDir() |
test/replay/app_replay_e2e_test.go
Outdated
| replayerTempDir, err := os.MkdirTemp("", "test-app-event") | ||
| require.NoError(t, err) | ||
|
|
||
| defer os.RemoveAll(driverTempDir) |
There was a problem hiding this comment.
with t.TempDir() we don't have to remove dir, they get rm after test finishes
There was a problem hiding this comment.
sounds good !
Though defer has this advantage that it is also run if code in test panics for whatever reason, and TempDir register cleanup in internal cleanups list which may not run in case of panic.
test/replay/app_replay_e2e_test.go
Outdated
| defer os.RemoveAll(replayerTempDir) | ||
| driver := NewBabylonAppDriver(t, driverTempDir, replayerTempDir) | ||
|
|
||
| for i := 0; i < 11; i++ { |
There was a problem hiding this comment.
maybe const the number 11 to denote what it means
There was a problem hiding this comment.
ahh good point :) this is to go over the epoch boundary and see that our checkpointing is working as expected
KonradStaniec
deleted the
konradstaniec/add-sending-tx-to-replay-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.