fix: Non-determinism in sorting finality providers in the voting power table #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
Lazar955,
samricotta,
SebastianElvis and
KonradStaniec
and removed request for
a team
gitferry
added
consensus breaking
KonradStaniec
approved these changes
Oct 11, 2024
gitferry
added a commit
that referenced
this pull request
Oct 11, 2024
…r table (#180) Non-determinism is caused due to not considering cases where both two items are jailed or non-timestamped, and when voting power is equal. This PR addressed this by determining the order in those cases by the increasing order of btc pk hex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-determinism is caused due to not considering cases where both two items are jailed or non-timestamped, and when voting power is equal. This PR addressed this by determining the order in those cases by the increasing order of btc pk hex.