Set PG dialect While Running FKEY checks #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 20, 2025 09:17
shah-nirmit
commented
Jan 21, 2025
| @@ -1783,8 +1783,7 @@ bool IsTsqlTableVariable(Relation relation) | |||
| { | |||
| return sql_dialect == SQL_DIALECT_TSQL | |||
| && relation | |||
| && relation->rd_rel->relpersistence == RELPERSISTENCE_TEMP | |||
| && relation->rd_rel->relname.data | |||
| && relation->rd_rel->relpersistence == RELPERSISTENCE_TEMP | |||
There was a problem hiding this comment.
Had to fix this due to following build error
queryenvironment.c: In function ‘IsTsqlTableVariable’:
queryenvironment.c:1787:17: error: the comparison will always evaluate as ‘true’ for the address of ‘data’ will never be NULL [-Werror=address]
1787 | && relation->rd_rel->relname.data
| ^~
In file included from ../../../../src/include/postgres.h:45,
from queryenvironment.c:23:
../../../../src/include/c.h:742:25: note: ‘data’ declared here
742 | char data[NAMEDATALEN];
|
There was a problem hiding this comment.
I think the original check was aimed at being NULL safe, so we should still add
&& relation->rd_rel->relname
Although I am not sure how relname would ever be NULL, but still good to have.
shah-nirmit
commented
Jan 21, 2025
| @@ -15,6 +15,7 @@ jobs: | |||
| run: | | |||
| sudo apt update --fix-missing -y | |||
| sudo apt install -y libipc-run-perl | |||
| sudo apt-get install -y libreadline-dev | |||
There was a problem hiding this comment.
Was getting build error
checking for library containing pthread_barrier_wait... none required
checking for library containing readline... no
configure: error: readline library not found
If you have readline already installed, see config.log for details on the
failure. It is possible the compiler isn't looking in the proper directory.
Use --without-readline to disable readline support.
There was a problem hiding this comment.
Probably better to configure engine with --without-readline.
tanscorpio7
suggested changes
Jan 24, 2025
| @@ -430,11 +430,11 @@ RI_FKey_check(TriggerData *trigdata) | |||
| * referenced side. The reason is that our snapshot must be fresh in | |||
| * order for the hack in find_inheritance_children() to work. | |||
| */ | |||
| ri_PerformCheck(riinfo, &qkey, qplan, | |||
| RUN_AS_PSQL(ri_PerformCheck(riinfo, &qkey, qplan, | |||
There was a problem hiding this comment.
We need to change RUN_AS_PSQL macro a bit.
We should directly set sql_dialect using its global variable rather than set_config.
tanscorpio7
suggested changes
Jan 24, 2025
| @@ -1783,8 +1783,7 @@ bool IsTsqlTableVariable(Relation relation) | |||
| { | |||
| return sql_dialect == SQL_DIALECT_TSQL | |||
| && relation | |||
| && relation->rd_rel->relpersistence == RELPERSISTENCE_TEMP | |||
| && relation->rd_rel->relname.data | |||
| && relation->rd_rel->relpersistence == RELPERSISTENCE_TEMP | |||
There was a problem hiding this comment.
I think the original check was aimed at being NULL safe, so we should still add
&& relation->rd_rel->relname
Although I am not sure how relname would ever be NULL, but still good to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On TSQL Endpoint, When Using Temp Table Inside Trigger, we plan the Referential Integrity(RI) check queries in
PG_DIALECTbut were not executing them using the same dialect they were planned in , which led to improper plan invalidation and incorrect namespace search path resolution.Fixes babelfish-for-postgresql/babelfish_extensions#3058
Issues Resolved
BABEL-5270
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.