Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSS-ONLY] Enable ddl_func_proc and ddl_partitions in DDL Export Tests #3489

Merged

Conversation

shalinilohia50
Copy link
Contributor

Description

Enable ddl_func_proc and ddl_partitions tests in DDL Export Framework.

  • Added the expected output files
  • The diff should strips trailing carriage return characters because we are comparing files with different line ending conventions (e.g., Windows CRLF vs Unix LF).
  • The diff should be unified, it is more readable than the default diff output.
  • Updated expected out for ddl_tables_index as we store the original index name now.

Issues Resolved

Task: BABEL-5616
Signed-off-by: Shalini Lohia [email protected]

Test Scenarios Covered

  • Use case based - Added tests in dotnet

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

babelfish-for-postgresql#3485)

Enable ddl_func_proc and ddl_partitions tests in DDL Export Framework.

    Added the expected output files
    The diff should strips trailing carriage return characters because we are comparing files with different line ending conventions (e.g., Windows CRLF vs Unix LF).
    The diff should be unified, it is more readable than the default diff output.
    Updated expected out for ddl_tables_index as we store the original index name now.

Task: BABEL-5616

Signed-off-by: Shalini Lohia [email protected]
@shardgupta shardgupta merged commit 1b0fa80 into babelfish-for-postgresql:BABEL_4_X_DEV Feb 12, 2025
48 checks passed
@shardgupta shardgupta deleted the jira-5616-4x branch February 12, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants