Add MIN and MAX aggregate support for MONEY datatype #3410
+1,182
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue where SELECT...INTO with MIN and MAX aggregations on MONEY columns lost type information. The fix implements proper type preservation for these aggregate functions when used with MONEY datatypes. Key changes: Added support for MIN(money) -> money Added support for MAX(money) -> money Ensures type consistency in SELECT...INTO operations Task: BABEL-5479 Signed-off-by: Roshan Kanwar <[email protected]>
roshan0708
force-pushed
the
JIRA-BABEL-5479
branch
from
2a2f007 to
5e51406
Compare
Pull Request Test Coverage Report for Build 12856128328Details
💛 - Coveralls |
thephantomthief
approved these changes
Jan 16, 2025
Deepesh125
reviewed
Jan 16, 2025
Deepesh125
requested changes
Jan 20, 2025
| GO | ||
|
|
||
| -- Complex Dependent Objects Test | ||
| CREATE VIEW MoneyView AS SELECT Amount FROM TestMoneyTable; |
There was a problem hiding this comment.
also select max(amount) from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit addresses the issue where
SELECT...INTOwithMINandMAXaggregations onMONEYcolumns lost type information. The fix implements proper type preservation for these aggregate functions when used with MONEY datatypes.Key changes:
Added support for MIN(money) -> money
Added support for MAX(money) -> money
Ensures type consistency in SELECT...INTO operations
Issues Resolved
Task: BABEL-5479
Test Scenarios Covered
Use case based - y
Boundary conditions - y
Arbitrary inputs - y
Negative test cases - y
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.