Fix transformation of <script> tags. Closes #84

The problem was that the transformScriptTags attached to DOMContentLoaded took one argument (the event), which it was treating as a list of script tags to transform. This is obviously wrong. DOM-specific stuff like this needs more unit testing in babel-standalone. Tested scriptTag-src.html and scriptTag-custom.html examples, both work as expected
babel · May 16, 2017 · 225703f · 225703f
1 parent 7408d19
commit 225703f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "babel-standalone",
-  "version": "6.24.1",
+  "version": "6.24.2",
   "description": "Standalone build of Babel for use in non-Node.js environments. Similar to the (now deprecated) babel-browser",
   "main": "babel.js",
   "scripts": {

diff --git a/src/index.js b/src/index.js
@@ -257,7 +257,7 @@ export const version = VERSION;
 // Listen for load event if we're in a browser and then kick off finding and
 // running of scripts with "text/babel" type.
 if (typeof window !== 'undefined' && window && window.addEventListener) {
-  window.addEventListener('DOMContentLoaded', transformScriptTags, false);
+  window.addEventListener('DOMContentLoaded', () => transformScriptTags(), false);
 }
 
 /**
@@ -274,4 +274,3 @@ export function transformScriptTags(scriptTags) {
 export function disableScriptTags() {
   window.removeEventListener('DOMContentLoaded', transformScriptTags);
 }
-
diff --git a/src/transformScriptTags.js b/src/transformScriptTags.js
@@ -184,12 +184,9 @@ function loadScripts(transformFn, scripts) {
  * Run script tags with type="text/jsx".
  * @param {Array} scriptTags specify script tags to run, run all in the <head> if not given
  */
-export function runScripts(transformFn, scriptTags) {
-  let scripts
+export function runScripts(transformFn, scripts) {
   headEl = document.getElementsByTagName('head')[0];
-  if(scriptTags) {
-    scripts = scriptTags
-  } else {
+  if (!scripts) {
     scripts = document.getElementsByTagName('script');
   }