Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CORS handling for requests responded with errors #181

Merged

Conversation

gcotelli
Copy link
Member

  • Use the available CORS configuration to set the expected headers in case the HTTPClientError handler kicked-in.
  • Fix the global error handler configured in StargateApplication to pay attention to CORS.
  • Improve tests related to CORS.

Fixes #180

Use the available CORS configuration to set the expected headers in case the HTTPClientError handler kicked-in.
Fix the global error handler configured in StargateApplication to pay attention to CORS.
Improve tests related to CORS.

Fixes #180
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1ca293) 99.53% compared to head (c045270) 99.54%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release-candidate     #181      +/-   ##
=====================================================
+ Coverage              99.53%   99.54%   +0.01%     
=====================================================
  Files                    164      166       +2     
  Lines                  13002    13306     +304     
=====================================================
+ Hits                   12941    13245     +304     
  Misses                    61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gcotelli gcotelli merged commit 28dff6e into release-candidate Nov 23, 2023
92 checks passed
@gcotelli gcotelli deleted the 180-500-Responses-doesnt-have-CORS-support branch November 23, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 Responses doesn't have CORS support
3 participants