Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Examples revised to IFC4.3RC3 #84

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jmirtsch
Copy link
Collaborator

Examples were disabled during Release Candidate publishing. They were not compliant with recent versions of IFC.
I've revised them according to IFC4.3RC3 and validated them with the KIT checker.

Alignment examples (and other infrastructure examples) will need to be revised in a separate task.

@jmirtsch jmirtsch added the documentation Issues or pull requests relating to documentation label Jun 22, 2021
@jmirtsch jmirtsch requested a review from SergejMuhic June 22, 2021 05:54
@pjanck
Copy link
Member

pjanck commented Jun 27, 2021

Before I start reviewing these files, I'd propose to wait for RC4 and I'll try and run them through TUM OpenInfraPlatform with a script. I can then check against the screen shots from 4x1 version of the standard and prove:

  • files have no syntax mistakes (my parser will complain)
  • files can be visualized (at least that there are no mistakes in geometry)

I cant vouch for other content, though. What do you think?

@SergejMuhic
Copy link
Collaborator

Maybe could run the IfcKit over this also. I will postpone this a bit then.

@SergejMuhic SergejMuhic added the backlog Issue to be resolved at a later date. label Jul 6, 2021
@pjanck pjanck added the Legacy Issues stemming from before 2023.01.01. label Mar 15, 2023
@pjanck pjanck added the reconcile Reconciliation conten with 4.3.2.0 label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue to be resolved at a later date. documentation Issues or pull requests relating to documentation Legacy Issues stemming from before 2023.01.01. reconcile Reconciliation conten with 4.3.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants