Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IfcGradient #550
base: tunnel
Are you sure you want to change the base?
IfcGradient #550
Changes from 7 commits
8b1b34c
4d0a278
6fcc215
34a0654
d53b720
177389e
38804f7
7eb4849
454551c
f19ce7a
b80afa0
bcbc77a
90f8b86
08fbcef
4388822
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation document is missing. Proposal for a first draft:
The IfcGradient function derives the height of any position (Position) along a IfcGradientCurve (GradientCurve). It iterates the gradient segments (GradientCurve.Segments) and retrieves the height from the segment's start height, segment's placement, and segment's ParentCurve instance and type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propose to call it
NextLocation
to clearly encode that it is the location of the next segment.