Add v13 compatibility #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochorocho
force-pushed
the
task/v13
branch
7 times, most recently
from
403bb05 to
043bf0c
Compare
bmack
approved these changes
Jan 14, 2025
achimfritz
reviewed
Jan 15, 2025
| if ($row === false) { | ||
| ->executeQuery() | ||
| ->fetchAllAssociative(); | ||
| if ($row === []) { |
There was a problem hiding this comment.
fetchAssociative() "Returns the next row of the result as an associative array or FALSE if there are no more rows."
i think the old condition was right.
There was a problem hiding this comment.
ah, sorry, here you use fetchAllAssociative(), so conditiion is correct, but above it is wrong.
but here the fetchAllAssociative() seems the wrong method, you should use fetchAssociative(), to get a single row, because
(new Job())->fromDatabaseRow($row) expect on database row, and not an array of database rows
i think you have to recheck the fetch-Methods
There was a problem hiding this comment.
Thanks @achimfritz fixed it.
achimfritz
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.