Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: narrow return type for min(), max(), median() and mean() #464

Merged
merged 1 commit into from
Apr 6, 2024
Merged

feat: narrow return type for min(), max(), median() and mean() #464

merged 1 commit into from
Apr 6, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Apr 6, 2024

Consider whether the input is empty or not

@coveralls
Copy link

coveralls commented Apr 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8580273017

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.781%
Totals Coverage Status
Change from base Build 8571532296: 0.0%
Covered Lines: 4377
Relevant Lines: 4431
💛 - Coveralls

@simPod
feat: narrow return type for min(), max(), median() and mean()
8ce6c56 
Consider whether the input is empty or not
@azjezz azjezz added this to the 3.0.0 milestone Apr 6, 2024
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Apr 6, 2024
@azjezz azjezz merged commit a33de34 into azjezz:next Apr 6, 2024
14 checks passed
@azjezz
Copy link
Owner

azjezz commented Apr 6, 2024

Thank you @simPod 🙏

@simPod simPod deleted the narrow branch April 6, 2024 15:02
simPod added a commit to simPod/psl that referenced this pull request Apr 18, 2024
@simPod
feat(math): narrow return type for min(), max(), median() and `…
69c44f0 
…mean()` (azjezz#464)
simPod added a commit to simPod/psl that referenced this pull request May 6, 2024
@simPod
feat(math): narrow return type for min(), max(), median() and `…
48b9aff 
…mean()` (azjezz#464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simPod @coveralls @azjezz