fix(hook): OnBeforeInitTalentForLevel #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Yehonal |
|
Looks like we've got a bit of a conflict with the CI here and on azerothcore-wotlk and we'll have to merge one or the other in first to resolve it since this is pulling master from there to run the clang build. |
Winfidonarleyan
approved these changes
Aug 18, 2021
|
let's merge the on in azerothcore-wotlk and later this |
Helias
changed the title
Helias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sister PR to azerothcore/azerothcore-wotlk#7389 to fix the usage of this hook within this module as it's used for testing builds.
Prior to this the hook wasn't fired at all so probably dead code here but might as well make it fit.