refactor: reduces duplication in sort-union-types and sort-intersection-types
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugop95
changed the title
sort-union-types and sort-intersection-typessort-union-types and sort-intersection-types
hugop95
force-pushed
the
refactor/sort-union-types
branch
from
b5f56c1 to
93a62e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The differences between the source code of
sort-union-typesandsort-intersection-typesare minimal (https://www.diffchecker.com/NZ9LSvo7/). Outside meta-related information (rule name, error IDs, etc), the only logic-related differences areWhen this rule is triggered (on union types vs on intersection types).
Partition by comment:
tokenValueToIgnoreBeforeeslint-plugin-perfectionist/rules/sort-union-types.ts
Line 206 in 0df348f
VS
eslint-plugin-perfectionist/rules/sort-intersection-types.ts
Line 206 in 0df348f
This PR creates a
sortUnionOrIntersectionTypesfunction that puts all of this logic in common to greatly reduce code duplication.No test impacted.
What is the purpose of this pull request?