feat: adds customGroup.newlinesBetweenrelated options
#430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We are going to be adding additional options in the next commit.
- We will be fixing them in a commit later.
…nodes - The `leftNum < rightNum` check is currently only made if `numberOfEmptyLinesBetween === 0` (as confirmed by passing tests). - With `newlinesBetween: always` and if `numberOfEmptyLinesBetween > 1`, we were not checking whether the two nodes were sorted or not before raising the spacing error. - This would result in two errors toward the same two nodes: - One related to invalid order. - The other related to invalid spacing. - A few tests had to be updated. - All of those errors targeted nodes that already had order errors reported for them.
…odes - The `leftNum < rightNum` check is not made when `newlinesBetween: never` either (as confirmed by passing tests). - A few tests had to be updated: - The fix itself has no change. There are only slightly less reported newlines errors. - All of those errors targeted nodes that already had order errors reported for them.
- Renames constants. - Simplifies `for` loop.
- Creates constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misclick.