refactor: uses Join for other rules
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugop95
force-pushed
the
refactor/rule-types
branch
3 times, most recently
from
65d08bd to
884c4a7
Compare
hugop95
force-pushed
the
refactor/rule-types
branch
from
884c4a7 to
e7046d2
Compare
OlivierZal
approved these changes
Dec 13, 2024
azat-io
reviewed
Dec 14, 2024
typings/join-with-dash.ts
Outdated
Comment on lines
1
to
10
| export type JoinWithDash<T extends string[]> = T extends [ | ||
| infer First extends string, | ||
| ...infer Rest extends string[], | ||
| ] | ||
| ? Rest extends [] | ||
| ? `${First}` | ||
| : `${WithDashSuffixOrEmpty<First>}${JoinWithDash<Rest>}` | ||
| : never | ||
|
|
||
| type WithDashSuffixOrEmpty<T extends string> = `${T}-` | '' |
There was a problem hiding this comment.
Looks good.
I have an idea. Maybe it makes sense to add a second Separator parameter?
export type Join<
T extends string[],
Separator extends string = '',
> = T extends [infer First extends string, ...infer Rest extends string[]]
? `${First}${Rest['length'] extends 0 ? '' : `${Separator}${Join<Rest, Separator>}`}`
: ''
export type JoinWithDash<T extends string[]> = Join<T, '-'>
azat-io
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Join,SortingNode.Joinintroduced in refactor(sort-classes): make group types readable #416 toJoinWithDashand uses it for other rules.What is the purpose of this pull request?