Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update svelte #149

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: update svelte #149

merged 2 commits into from
Jun 12, 2024

Conversation

tkhs0813
Copy link
Contributor

@tkhs0813 tkhs0813 commented May 22, 2024

Description

We will update the related Svelte packages.

Additional context

When adding eslint-plugin-perfectionist to a SvelteKit project created with npm create svelte@latest, the following error occurs. Therefore, we will update the related Svelte packages.

✝  git/study/eslint-plugin-perfectionist-example  npm install --save-dev eslint-plugin-perfectionist
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/svelte-eslint-parser
npm ERR!   svelte-eslint-parser@">=0.36.0 <1.0.0" from [email protected]
npm ERR!   node_modules/eslint-plugin-svelte
npm ERR!     dev eslint-plugin-svelte@"^2.35.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev eslint-plugin-perfectionist@"*" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/svelte-eslint-parser
npm ERR!   peerOptional svelte-eslint-parser@"^0.33.0" from [email protected]
npm ERR!   node_modules/eslint-plugin-perfectionist
npm ERR!     dev eslint-plugin-perfectionist@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
  • Read contribution guidelines.

@tkhs0813 tkhs0813 marked this pull request as ready for review May 22, 2024 03:19
@@ -124,7 +124,7 @@ export default createEslintRule<Options<string[]>, MESSAGE_ID>({
if (typeof attribute.key.name === 'string') {
;({ name } = attribute.key)
} else {
name = context.sourceCode.text.slice(...attribute.key.range!)
name = context.sourceCode.text.slice(...attribute.key.range)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the issue due to an ESLint error.

 ✝  study/fork/eslint-plugin-perfectionist   main±  node_modules/.bin/eslint "**/*.{js,ts}"

/Users/ryo.takahashi/git/study/fork/eslint-plugin-perfectionist/rules/sort-svelte-attributes.ts
  127:59  error  This assertion is unnecessary since it does not change the type of the expression  @typescript-eslint/no-unnecessary-type-assertion

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

@tkhs0813
Copy link
Contributor Author

tkhs0813 commented May 22, 2024

@azat-io
Hi! It is currently not available for use in the latest SvelteKit project. Could you please check it?

@tkhs0813
Copy link
Contributor Author

@azat-io
Hi!

I hope you're doing well. I wanted to follow up on the pull request I submitted. It's been a little while, and I wanted to check if there's anything more I need to do or if there are any updates regarding its review.

Thank you for your time and consideration. I appreciate the effort you and the team put into maintaining this project.

Best regards,

@azat-io azat-io merged commit 861a381 into azat-io:main Jun 12, 2024
5 checks passed
@azat-io
Copy link
Owner

azat-io commented Jun 12, 2024

Hi! I'm sorry for the long delay. Thank you for your contribution!

Released in v2.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants