fix(sort-imports): empty named imports being considered side-effect imports #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed a bug when writing some code in a project where I have set up this plugin (thank you by the way, it helps out a lot!). When I wrote a named import but didn't specify anything to be imported it was being considered a side-effect import and moved to the bottom of the list of imports. Turns out there is no way to distinguish a side-effect import from an empty named import from looking at the AST, so the only thing I could think of what to look for a
} from
string in the nodes code to make it not being considered a side-effect import 🙂Additional context
Output from AST explorer
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).