Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3712 Add Author Role to Publications #4075

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fixes #3712 Add Author Role to Publications #4075

wants to merge 5 commits into from

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Feb 14, 2025

Description

This PR introduces a field_az_contributors field, which uses a entity reference field subclass called az_entity_role_reference. This provides a reference field which has an additional property, role. This property is used to indicate the capacity in which someone contributed to a publication.

A widget is provided that is a subclass of inline entity form, to allow adding the role as part of the inline entity form interface.

This information is passed as part of the work's CSL schema to the CSL proccessor.

Related issues

Closes #3712

How to test

Not yet ready for testing

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added high priority Must get done for this milestone publications 2.13.x only labels Feb 14, 2025
@tadean tadean self-assigned this Feb 14, 2025
@tadean
Copy link
Contributor Author

tadean commented Feb 14, 2025

image

@tadean
Copy link
Contributor Author

tadean commented Feb 14, 2025

Todo:

  • Determine if this path seems appropriate
  • Formalize constraints and possible roles
  • Update inline entity form callback to not require entity comparison
  • Add database update to migrate field data to new field
  • Update views

@joeparsons joeparsons added the enhancement New feature or request label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.13.x only enhancement New feature or request high priority Must get done for this milestone publications
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Add Author Role to Publications
2 participants