Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match elim #1328

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Match elim #1328

wants to merge 14 commits into from

Conversation

dark-flames
Copy link
Contributor

No description provided.

@dark-flames dark-flames linked an issue Feb 16, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 92.64706% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (c98f94d) to head (4a0750c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
base/src/main/java/org/aya/tyck/ExprTycker.java 89.65% 1 Missing and 2 partials ⚠️
...ax/src/main/java/org/aya/syntax/concrete/Expr.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1328      +/-   ##
============================================
+ Coverage     83.63%   83.70%   +0.07%     
- Complexity     4191     4201      +10     
============================================
  Files           377      377              
  Lines         12118    12140      +22     
  Branches       1428     1432       +4     
============================================
+ Hits          10135    10162      +27     
+ Misses         1221     1217       -4     
+ Partials        762      761       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very high quality first PR! I'll patch the error report myself and you'll be good to go

syntax/src/main/java/org/aya/syntax/concrete/Expr.java Outdated Show resolved Hide resolved
@ice1000 ice1000 added this to the v0.38 milestone Feb 17, 2025
@ice1000 ice1000 added tyck: match core: match parser Lexer, parser, producer, parse tree, etc. concrete and removed tyck: match labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concrete core: match parser Lexer, parser, producer, parse tree, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match elim e
2 participants