-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform WHNF when pattern matching and invoke #1326
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
============================================
+ Coverage 83.62% 83.66% +0.03%
- Complexity 4168 4190 +22
============================================
Files 375 377 +2
Lines 12056 12116 +60
Branches 1425 1428 +3
============================================
+ Hits 10082 10137 +55
- Misses 1217 1220 +3
- Partials 757 759 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Currently, our PatternSerializer missing the part of whnf the argument, which may stuck in certain situations. Also,
TermExperialize
is responsible for doing someNormalizer
work, such as normalizing the argument beforeinvoke
.This PR:
UnaryOperator
argument (can beNormalizer
) toJitFn#invoke
,JitMatchy#invoke
, andJitCon#isAvailable
InvokeSignatureHelper
to handle the change above.