Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lsp changes #1313

Merged
merged 5 commits into from
Feb 11, 2025
Merged

More lsp changes #1313

merged 5 commits into from
Feb 11, 2025

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented Feb 11, 2025

TODO:

  • Fix potential threading problem of mutable states in AyaLanguageServer

@HoshinoTented HoshinoTented added this to the v0.38 milestone Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (a219469) to head (545bdaf).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1313   +/-   ##
=========================================
  Coverage     83.59%   83.59%           
  Complexity     4136     4136           
=========================================
  Files           373      373           
  Lines         11989    11989           
  Branches       1410     1410           
=========================================
  Hits          10022    10022           
  Misses         1220     1220           
  Partials        747      747           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000
Copy link
Member

ice1000 commented Feb 11, 2025

I don't see how the TODOs can be fixed immediately, nor am I sure about what should we lock. Naïvely we would just turn all the methods who mutate libraries() synchronized, but I don't know if it's correct.

@ice1000 ice1000 merged commit 37e8497 into main Feb 11, 2025
6 checks passed
@ice1000 ice1000 deleted the more-lsp branch February 11, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants