Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some profile-guided optimization #1305

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Some profile-guided optimization #1305

merged 5 commits into from
Feb 4, 2025

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Feb 4, 2025

Recursive buildNested has made the profiler output harder to read:
image

After turning it into iteration, it's easier:
image

The sourcePosForSubExpr is taking a lot of time. Shit!

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.59%. Comparing base (7c385f4) to head (0505c78).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1305      +/-   ##
============================================
+ Coverage     83.58%   83.59%   +0.01%     
- Complexity     4381     4382       +1     
============================================
  Files           396      396              
  Lines         12661    12664       +3     
  Branches       1451     1452       +1     
============================================
+ Hits          10583    10587       +4     
+ Misses         1304     1303       -1     
  Partials        774      774              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 marked this pull request as ready for review February 4, 2025 18:27
@ice1000 ice1000 added this to the v0.38 milestone Feb 4, 2025
@ice1000 ice1000 merged commit 06bc281 into main Feb 4, 2025
6 checks passed
@ice1000 ice1000 deleted the ice1000 branch February 4, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant