An attempt to redo #1226 #1298
Closed
An attempt to redo #1226 #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ice1000 <[email protected]>
Co-authored-by: 澪 <[email protected]>
This reverts commit 10ac7a6
… on generalize & contexts
ice1000
commented
Feb 1, 2025
| @@ -38,6 +39,6 @@ sealed interface ResolvingDecl extends ResolvingStmt { } | |||
|
|
|||
| record TopDecl(@NotNull Decl stmt, @NotNull Context context) implements ResolvingDecl { } | |||
| record MiscDecl(@NotNull Decl stmt) implements ResolvingDecl { } | |||
| record GenStmt(@NotNull Generalize stmt) implements ResolvingStmt { } | |||
| record GenStmt(@NotNull Generalize stmt, @NotNull ModuleContext context) implements ResolvingStmt { } | |||
There was a problem hiding this comment.
This is an important fix though
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1298 +/- ##
============================================
+ Coverage 83.44% 83.50% +0.05%
- Complexity 4260 4278 +18
============================================
Files 388 390 +2
Lines 12345 12395 +50
Branches 1429 1434 +5
============================================
+ Hits 10301 10350 +49
+ Misses 1290 1289 -1
- Partials 754 756 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I failed to solve the problem too. Opening this for review