Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classfile Morphism #1297

Merged
merged 11 commits into from
Feb 1, 2025
Merged

Classfile Morphism #1297

merged 11 commits into from
Feb 1, 2025

Conversation

HoshinoTented
Copy link
Contributor

@HoshinoTented HoshinoTented commented Jan 31, 2025

This PR introduces a morphism that targets jvm bytecode, which is much more efficient than java source code. However, jvm bytecode is so low-level and will have a lot of potential problems. We need more tests on this.

I also need more advice about bytecode generation.

@HoshinoTented HoshinoTented added this to the v0.38 milestone Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 89.52096% with 35 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (85cd353) to head (9f86bc1).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...aya/compiler/free/morphism/asm/AsmCodeBuilder.java 84.69% 16 Missing and 12 partials ⚠️
...ompiler/free/morphism/asm/AsmArgumentProvider.java 68.75% 2 Missing and 3 partials ⚠️
...in/java/org/aya/compiler/free/FreeExprBuilder.java 85.71% 0 Missing and 1 partial ⚠️
...aya/compiler/free/morphism/asm/AsmJavaBuilder.java 97.05% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1297      +/-   ##
============================================
+ Coverage     83.46%   83.62%   +0.16%     
- Complexity     4262     4371     +109     
============================================
  Files           388      395       +7     
  Lines         12353    12672     +319     
  Branches       1429     1449      +20     
============================================
+ Hits          10310    10597     +287     
- Misses         1290     1304      +14     
- Partials        753      771      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't done reading everything yet

@ice1000 ice1000 marked this pull request as ready for review February 1, 2025 21:45
@ice1000 ice1000 enabled auto-merge February 1, 2025 21:45
@ice1000 ice1000 merged commit 171c6ff into main Feb 1, 2025
4 checks passed
@ice1000 ice1000 deleted the classfile branch February 1, 2025 21:46
@ice1000 ice1000 mentioned this pull request Feb 1, 2025
ice1000 added a commit that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants