Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor Build Axon step in the workflows #1330

Closed
wants to merge 4 commits into from
Closed

chore: refactor Build Axon step in the workflows #1330

wants to merge 4 commits into from

Conversation

Flouse
Copy link
Contributor

@Flouse Flouse commented Aug 16, 2023 •
edited
Loading

What this PR does / why we need it?

cargo build takes a lot of time
=> This PR cache the building result with commit_id in the cache-key, so we don't have to build Axon from zero in every GitHub action workflow.
=> With cargo cache, the Build Axon step only takes 90 seconds.
=> The workflows such as openzeppelin_tests will consume ~20 mins less.

What is the impact of this PR?

  • No Breaking Change
  • improve efficiency in project building and testing，and may report bugs effectively
  • Perhaps in the near future, all tests could be triggered by default, not manually.
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

Flouse added 4 commits August 16, 2023 15:19
@Flouse
chore: build Axon in a reusable workflow
02c28dd 
chore(CI): test single node in ubuntu-22.04

chore(CI): archive axon-single-node-logs

chore: build Axon in a reusable workflow

chore(CI): remove start_single_node.yml
@Flouse
chore(CI): avoid using self-hosted runner in axon-start-with-short-ge…
799fafe 
…nesis.yml
@Flouse
CI: refactor workflows/openzeppelin_test_1_5_and_12_15.yml
eb133c7
@Flouse
refactor(CI): use reusable `build-axon' job to reduce time consuming
07347e8
@Flouse Flouse marked this pull request as ready for review August 18, 2023 02:33
@Flouse Flouse requested a review from a team as a code owner August 18, 2023 02:33
@Flouse Flouse requested review from jjyr, felicityin, KaoImin and yangby-cryptape and removed request for jjyr and felicityin August 18, 2023 02:33
@Flouse
Copy link
Contributor Author

Flouse commented Aug 21, 2023 •
edited
Loading

needs rebase after PR

@Flouse Flouse marked this pull request as draft August 21, 2023 02:29
@Flouse Flouse closed this Aug 21, 2023
@Flouse Flouse deleted the ci-refactor-axon-build branch August 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaoImin KaoImin Awaiting requested review from KaoImin

@yangby-cryptape yangby-cryptape Awaiting requested review from yangby-cryptape

Assignees
No one assigned
Labels
chore refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Flouse