ci(release): include Cargo.toml in release commit process #675
Conversation
WalkthroughThe pull request modifies the semantic release configuration in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.releaserc.cjs (1)
110-110: Consider adding a comment explaining the workspace-based versioning.To help future maintainers understand why only the root
Cargo.tomlis included, consider adding a comment in the configuration explaining that versions are managed through the workspace manifest."@semantic-release/git", { assets: [ "CHANGELOG.md", "docs/**", + // Only include root Cargo.toml as it's the workspace manifest managing versions "Cargo.toml", "Cargo.lock", ],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.releaserc.cjs(1 hunks)
🔇 Additional comments (1)
.releaserc.cjs (1)
110-110: LGTM! Verify workspace structure.
The change to include only the root Cargo.toml is correct since it appears to be a workspace manifest that manages versions for all member crates.
Let's verify the workspace structure:
✅ Verification successful
Workspace structure verified - root Cargo.toml manages all crates
The verification confirms that:
- Root
Cargo.tomlis indeed a workspace manifest managing all crates - Workspace members include all crates under
contracts/*andpackages/* - All existing Cargo.toml files (4 contracts, 6 packages) are properly covered by the workspace patterns
The change to include only the root Cargo.toml in semantic release is correct since it manages versions for all workspace members.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that root Cargo.toml is a workspace manifest
# and contains all necessary member references
# Check if root Cargo.toml exists and contains workspace members
rg -A 5 "^\[workspace\]" Cargo.toml
# List all Cargo.toml files in the repository for reference
fd Cargo.toml
Length of output: 544
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Self explanatory.
Summary by CodeRabbit
Cargo.tomlfiles.