-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually generate cognitarium schema and client #43
Conversation
WalkthroughThe changes across the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant gRPC Server
participant CosmWasm
Client->>gRPC Server: Send Request
gRPC Server->>CosmWasm: Forward Request
CosmWasm-->>gRPC Server: Response
gRPC Server-->>Client: Return Response
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
go/cognitarium-schema/client.go
is excluded by!go/**/*.go
go/cognitarium-schema/schema.go
is excluded by!go/**/*.go
Files selected for processing (4)
- go/cognitarium-schema/go.mod (1 hunks)
- go/dataverse-schema/go.mod (1 hunks)
- go/law-stone-schema/go.mod (1 hunks)
- go/objectarium-schema/go.mod (1 hunks)
Additional comments not posted (4)
go/cognitarium-schema/go.mod (1)
5-8
: Dependencies added successfully. Verify compatibility.The addition of
google.golang.org/grpc
andgithub.com/CosmWasm/wasmd
expands the module's capabilities. Ensure that these versions are compatible with the existing codebase and other dependencies.go/dataverse-schema/go.mod (1)
5-8
: Dependencies added successfully. Verify compatibility.The addition of
google.golang.org/grpc
andgithub.com/CosmWasm/wasmd
enhances the module's capabilities. Ensure that these versions are compatible with the existing codebase and other dependencies.go/law-stone-schema/go.mod (1)
5-8
: Dependencies added successfully. Verify compatibility.The addition of
google.golang.org/grpc
andgithub.com/CosmWasm/wasmd
enhances the module's capabilities. Ensure that these versions are compatible with the existing codebase and other dependencies.go/objectarium-schema/go.mod (1)
6-7
: Verify the necessity and compatibility of new dependencies.The addition of
google.golang.org/grpc
andgithub.com/CosmWasm/wasmd
suggests new functionalities. Ensure these dependencies are necessary for the module and compatible with the existing codebase.Verification successful
Dependencies are necessary and used in the codebase.
The
google.golang.org/grpc
andgithub.com/CosmWasm/wasmd
dependencies are utilized ingo/cognitarium-schema/client.go
, indicating their necessity for the current implementation. Ensure that these versions are compatible with other dependencies and the overall project requirements.
google.golang.org/grpc
is used for theQueryClient
interface.github.com/CosmWasm/wasmd
is imported aswasmtypes
.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the newly added dependencies to ensure they are necessary and compatible. # Test: Search for usage of grpc and wasmd packages in the module. # Expect: Occurrences of grpc and wasmd usage in the codebase. rg --type go 'google.golang.org/grpc|github.com/CosmWasm/wasmd' --context 5Length of output: 1439
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR addresses issues with generating the
cognitarium
schema using thego-codegen
library. Despite modifications to thego-codegen
library, the generation process encountered issues with theValue
struct. To resolve this, the generated code was manually rewritten with a fixed version. This PR is based on the schema contract v6.0.0 (latest release).