Filterx initial string cache #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The convention is that we are using FilterXObject pointers in interfaces, and potentially check if the object at runtime matches our expectations. By using FilterXString instances there, we typed constructors as well as publish FilterXString as a struct. I am not against publishing internal structs if they serve optimization purposes, but any value should rather be passed around as objects and not specific types. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…ings Signed-off-by: Balazs Scheidler <[email protected]>
MrAnno
reviewed
Jan 27, 2025
| @@ -146,7 +147,8 @@ filterx_getattr_new(FilterXExpr *operand, FilterXString *attr_name) | |||
| self->super.free_fn = _free; | |||
| self->operand = operand; | |||
|
|
|||
| self->attr = (FilterXObject *) attr_name; | |||
| filterx_object_is_type(attr_name, &FILTERX_TYPE_NAME(string)); | |||
| self->attr = attr_name; | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the caching of trivial FilterXString instances (e.g. zero-length and single character numbers), which are commonly found in our log patterns as string values. Instead of allocating these all the time, use a cached instance.
This is "initial" string cache, as I have some pending patches to implement a larger table of strings that could be cached
similarly, but I got to make more testing with those to see how they impact performance.