-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filterx pubsub message #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pull Request introduces config grammar changesaxoflow/e814ffbb404072b7e293fbfca97989c1796b11f9 -> bshifter/fx-pubsub --- a/destination
+++ b/destination
google-pubsub-grpc(
+ proto-var(
+ <template-content>
+ <template-reference>
+ )
)
|
f7510c9
to
d15fbc7
Compare
318dbda
to
471948f
Compare
alltilla
reviewed
Jan 17, 2025
2fe1e2c
to
ff70e44
Compare
alltilla
reviewed
Jan 21, 2025
Thanks for the updates on the PR. I found a couple more things that I unfortunately missed the last time. |
Signed-off-by: shifter <[email protected]>
The implementation follows the existing patterns and designs of the OpenTelemetry (OTel) filterx modules for consistency. Signed-off-by: shifter <[email protected]>
The protovar option in the Pub/Sub destination allows users to directly access the Protobuf byte representation created by a FilterX function on the source side. The Protobuf serialized variable is used to set the Pub/Sub message's content. This enables users to fully control and manage the outgoing messages of the Pub/Sub destination from within FilterX. By leveraging this option, users can customize the message payload dynamically, based on their specific requirements. The data() and attributes() options cannot be used with protovar(). These options are mutually exclusive. Signed-off-by: shifter <[email protected]>
Signed-off-by: shifter <[email protected]>
alltilla
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pubsub_message() function to FilterX and extend Pub/Sub destination with protovar
This PR introduces new functionality for managing Google Pub/Sub messages in syslog-ng:
Together, these changes provide greater flexibility and control over Pub/Sub destination messages, supporting advanced customization directly from FilterX.
example: