Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterx keys function #435

Merged
merged 5 commits into from
Dec 31, 2024
Merged

filterx keys function #435

merged 5 commits into from
Dec 31, 2024

Conversation

bshifter
Copy link
Member

example:

            d = {"foo":1,"bar":[3,2,1],"baz":{"tik":"tak"}};
            $MSG.keys = keys(d); #["foo","bar","baz"]
            $MSG.elt = keys(d)[0]; #"foo"

Copy link
Member

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, also I feel increasingly that the function support code needs to be improved, there's still to much boiler plate around creating a function and writing its argument parsing.

In a similar vein, I'd want to turn FilterXFunction as an expr into a FilterXCall, which operates on various function types, e.g. simple and generator and generic, each with more supporting framework to help facilitate the writing of those functions.

But that's just a side note, this one can go in even with the extra argument check. I'd appreciate the removal of all similar checks as a separate PR though.

@bazsi bazsi merged commit 6cf486f into axoflow:main Dec 31, 2024
22 checks passed
@alltilla
Copy link
Member

alltilla commented Jan 2, 2025

@bshifter Can you please create a newsfile entry for this in another PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants