Filterx: check if value is a macro during compilation #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-check-if-value-is-a-macro-during-compilation
branch
2 times, most recently
from
ce6cd7b to
1871070
Compare
bazsi
force-pushed
the
filterx-check-if-value-is-a-macro-during-compilation
branch
2 times, most recently
from
f8570fd to
9d55fc3
Compare
bazsi
changed the title
The special handling for $MSG is long gone, avoid handling $MSG as a macro as it requires extra copying in filterx and there's no functional requirement anymore. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Instead of doing this in the hot path. Also eliminate the related helper function. Signed-off-by: Balazs Scheidler <[email protected]>
… non-zero To match how object-bytes/object-protobuf works. Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
It took me a while to realize why the output is not rendered in our light tests, once I removed $MSG as a macro. This message would have helped me a lot. Signed-off-by: Balazs Scheidler <[email protected]>
With the $MSG as a macro gone, $MSG became a typed value, so it does matter what we set it to. Since setting it to a bytes/protobuf value means that its not a string anymore, we can't render it as a part of a template unless we explicitly ask for the right type hint. This is what this patch changes in the broken testcases. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-check-if-value-is-a-macro-during-compilation
branch
from
9d55fc3 to
f8e6cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ended a bit more than what the title says:
With all that fixed is what we have in this branch.