Filterx location tracking for all exprs #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazsi
force-pushed
the
filterx-location-tracking-for-all-exprs
branch
2 times, most recently
from
8c1422b to
0ae5d86
Compare
Only exprs added as a stmt_expr had location information, meaning that conditions or exprs in ternaries did not have location information. Add those as well. Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
filterx-location-tracking-for-all-exprs
branch
from
0ae5d86 to
7d3b7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds location information for non-statement expressions, which means we would see less of those "n/a" locations.