-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralized internal logging #364
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
59cc5ad
lib/logmsg: remove unused function declaration
OverOrion 8ee08ba
lib/messages: add LogMessage rcptid field to MsgContext
OverOrion 3394f13
lib/messages: add msg rcptid printing to msg_event_create
OverOrion 3a25988
all: remove duplicate rcptid printing
OverOrion 525a26b
lib: remove msg_set_context(NULL) calls
OverOrion 9845822
modules/systemd-journal: move msg_set_context sooner
OverOrion 759ed69
all: consolidate msg_set_context calls
OverOrion 467f8f5
lib/logscheduler: call msg_set_context
OverOrion a18d0aa
lib: remove msg_set_context calls at sending side
OverOrion a544905
all: add msg_set_context() calls for LogThreadedSourceDriver subclasses
OverOrion e3c8d2b
all: add msg_set_context() calls for LogThreadedFetcherDriver subclasses
OverOrion 0743300
lib/logsource: remove msg_set_context() call
OverOrion 02093f9
lib/logmsg: remove obsolete evt_tag_msg_reference macro
OverOrion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to track
the message we are currently working on globally (per-thread)
. This idea will always imply a certain amount of layering violation, but placing this call into LogMessage constructors wouldn't necessarily help as I'm not sure we want to track each message that pops into existence.For example, what do we want to do with synthetic messages produced by the
grouping-by()
and PatternDB parsers? And internal messages of course, which we don't want to track.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this question is answered, I think we can introduce a function that can help reduce these set_context calls at least on the source and processing side.