Fix mainloop hang in case job submission fails #349
Conversation
alltilla
force-pushed
the
fix-mainloop-hang-in-case-job-submission-fails
branch
from
b660f7b to
de7db68
Compare
|
@bazsi |
| @@ -573,7 +573,11 @@ log_reader_io_handle_in(gpointer s) | |||
| log_reader_disable_watches(self); | |||
| if ((self->options->flags & LR_THREADED)) | |||
| { | |||
| main_loop_io_worker_job_submit(&self->io_job, NULL); | |||
| if (!main_loop_io_worker_job_submit(&self->io_job, NULL)) | |||
There was a problem hiding this comment.
This can only fail if main_loop_workers_quit is set, but in that case, we should not retry.
If my assumption is correct, this patch depends on work on a different branch.
There was a problem hiding this comment.
That is possible. Talked IRL with Bazsi, and concluded that this PR is meaningful on its own, but I might have misunderstood something. Sorry if so.
There was a problem hiding this comment.
We talked about this IRL, registering a task in the debugger would hopefully resolve the issue in a cleaner way.
bazsi
force-pushed
the
fix-mainloop-hang-in-case-job-submission-fails
branch
from
de7db68 to
5ba6d4d
Compare
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
fix-mainloop-hang-in-case-job-submission-fails
branch
from
5ba6d4d to
3685e80
Compare
|
we could not reproduce the problem and clearly this is not the right solution. |
No description provided.