-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filterx parse leef 2.0 #343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshifter
force-pushed
the
filterx-parse-leef2
branch
2 times, most recently
from
October 16, 2024 18:01
86e8938
to
79f13cb
Compare
alltilla
reviewed
Nov 8, 2024
bshifter
force-pushed
the
filterx-parse-leef2
branch
from
November 8, 2024 14:20
79f13cb
to
dcd0227
Compare
… data without using expected columns mode Signed-off-by: shifter <[email protected]>
…for improved thread safety. This was required to accommodate the dynamic parsing of the optional delimiter field in LEEF 2.0. Additionally, introduce optional arguments named `field_separator` and `value_separator` in the filterx function to enforce specific separators. Signed-off-by: shifter <[email protected]>
…lterx function. Signed-off-by: shifter <[email protected]>
…EEF 2.0 version. Changes include: - Updated usage message - Enhanced version parsing - Added optional 'delimiter' field to parse and configure the LEEF extension's pair separator based on the specified delimiter value. Signed-off-by: shifter <[email protected]>
- Moved to a separate unit to improve organization due to their size - Implemented `va_args` functions for more flexible construction of filterx function arguments - Generalized helper functions to reduce code duplication in CEF/LEEF tests Signed-off-by: shifter <[email protected]>
- Utilize the updated test helpers module - Include additional tests for enforcing pair-separator and value-separator functionality Signed-off-by: shifter <[email protected]>
- Utilize the updated test helpers module - Include additional tests for enforcing pair-separator and value-separator functionality - Add extra tests for parsing and utilizing the optional `delimiter` field in LEEF 2.0 Signed-off-by: shifter <[email protected]>
bshifter
force-pushed
the
filterx-parse-leef2
branch
from
November 8, 2024 15:14
dcd0227
to
6ba689f
Compare
alltilla
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the LEEF 2.0 format, specifically focusing on its dynamic header field,
delimiter
. The task required a significant refactor of the event-parser base module and the unit test framework. Additionally, it introduces optional named arguments for the filterx function, allowing for forced overrides ofpair-separator
andvalue-separator
. This enhancement will enable us to parse specific non-standard CEF/LEEF messages more effectively.examples: