cfg: fix config-version incosistencies #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template functions, for example, are constructed right when AxoSyslog parses the configuration, so the `@version` directive must be placed at the top of the config file to make it consistent. This patch fixes the implicit "current version" mechanism (when no `@version` is specified) by moving it back to the lexer, and warns the user about misplaced or redefined `@version` directives. Signed-off-by: László Várady <[email protected]>
Signed-off-by: László Várady <[email protected]>
|
Reproducer: Place a |
OverOrion
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template functions, for example, are constructed right when AxoSyslog parses the configuration, so the
@versiondirective must be placed at the top of the config file to make it consistent.This patch fixes the implicit "current version" mechanism (when no
@versionis specified) by moving it back to the lexer, and warns the user about misplaced or redefined@versiondirectives.