light: Add 3 minor fixes for a: deprecation warning, flaky testcase and crash detection #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitzkia
changed the title
mitzkia
changed the title
mitzkia
changed the title
MrAnno
previously approved these changes
Sep 23, 2024
- `psutil.Process().connections()` became deprecated Signed-off-by: Andras Mitzki <[email protected]>
- sometimes (between 5 and 7 times out of 20 executions) at the end of the testcase (line 190) 'syslogng_metric' Prometheus sample value will not included however other values are exist in ctl output - this is fix waits until the sample is not empty (usually for the second query it will be there) Signed-off-by: Andras Mitzki <[email protected]>
- My opinion is that after dbld containers are no more depending on gosu,
core files could not generated inside.
- 'docker run --ulimit core=unlimited ...' will not take effect while using
(in entrypoint.sh)
```
exec sudo --preserve-env --preserve-env=PATH -Hu "${USER_NAME}" "$@"
```
- after this fix light will detect if syslog-ng has crashed with known
signals
Signed-off-by: Andras Mitzki <[email protected]>
mitzkia
force-pushed
the
light-various-fixes
branch
from
e2b17b5 to
15f4f9e
Compare
|
Thanks for the review and for the approve. I have fixed the |
MrAnno
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These minor fixes helps to run light more comfortable.
psutil.Process().connections())