fix: parse JSON with UTF-8 BOMs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
Mar 14, 2024
While many JSON parsers can read UTF-8 data that begins with a byte order mark, json-serde can't. This caused an error for us when reading data that originated from PowerShell on Windows, which always writes a byte order mark at the beginning of the file even when using UTF-8.
mistydemeo
force-pushed
the
strip_json_bom
branch
from
c0bb479 to
b6d5287
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While many JSON parsers can read UTF-8 data that begins with a byte order mark, json-serde can't. This caused an error for us when reading data that originated from PowerShell on Windows, which always writes a byte order mark at the beginning of the file even when using UTF-8.
I've added a test for this and confirmed the new test fails without the new changes.
See: serde-rs/json#1115