Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test with query status messages #152

Merged
merged 2 commits into from
Nov 11, 2024
Merged

test: Add test with query status messages #152

merged 2 commits into from
Nov 11, 2024

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Nov 9, 2024

This tries to reproduce #151.

self.assertEqual(
qr.status.messages[0].msg,
"line: 1, col: 24: where clause always evaluates to TRUE, which will include all data",
)
Copy link

@martijnthe martijnthe Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with your test set up / fixtures.
Does this query a "real" Axiom server?

Are you seeing the apl_whereclausealwaysevaluatestoTRUEwhichwillincludealldata_5 string in the response as the "code"? If not, maybe something changed in the backend/server? (see screenshot in my issue).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this calls the real Axiom API. I've added an assert for the code as well.

Copy link
Contributor

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darach darach merged commit 9c53168 into main Nov 11, 2024
7 checks passed
@darach darach deleted the arne/test-messages branch November 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants