Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for tabular format #136

Merged
merged 4 commits into from
Sep 13, 2024
Merged

feat: Add support for tabular format #136

merged 4 commits into from
Sep 13, 2024

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Sep 12, 2024 •
edited
Loading

  • Replace MessageCode w/ str as we have no way of knowing future message codes
  • Adds support for the tabular format
  • Adds iterator support to each table for better ergonomics

@bahlo bahlo marked this pull request as draft September 12, 2024 15:35
@bahlo bahlo marked this pull request as ready for review September 12, 2024 17:49
@bahlo bahlo marked this pull request as draft September 12, 2024 17:54
Licenser
Licenser reviewed Sep 13, 2024
View reviewed changes
Copy link

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 tabularaza

src/axiom_py/query/result.py Outdated Show resolved Hide resolved
src/axiom_py/query/result.py Show resolved Hide resolved
@bahlo bahlo marked this pull request as ready for review September 13, 2024 08:35
Licenser
Licenser approved these changes Sep 13, 2024
View reviewed changes
Copy link

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@bahlo bahlo merged commit 7b6c84c into main Sep 13, 2024
7 checks passed
@bahlo bahlo deleted the arne/add-tabular branch September 13, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Licenser Licenser Licenser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahlo @Licenser