[feat] add bits_to_num
and limbs_to_num
#222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple of functions to reconstruct field elements from their bit/limb representations
bits_to_num
toGateInstructions
limbs_to_num
toRangeInstructions
Assumes the bit/limb representation is valid and doesn't range check the bits/limbs.
One thing to note is that there can be multiple bit/limb representations that map to the same field element. For eg. with 254 bits and working on BN254, both the bit representations of
x
andx + p
(254 bits) will map tox
. It might make sense to range check the input to be less thanp
in such a case