-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Keccak Coprocessor Leaf Circuit #130
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d178862
WIP
nyunyunyunyu 6645171
chore: make `KeccakAssignedRow` fields public
jonathanpwang e1b04eb
Refactor Keccak coprocessor circuit
nyunyunyunyu f33c5d3
Optimize Keccak circuit MAX_DEGREE
nyunyunyunyu 7d8a24b
Fix comments
nyunyunyunyu e2cfa9e
Fix bug & typos
nyunyunyunyu efd12dd
Add testing & refactor folder structure
nyunyunyunyu 7bc2f04
Debugging
nyunyunyunyu eca1636
Fix bugs
nyunyunyunyu 48200b1
Fix typo & bug
nyunyunyunyu a2da6ac
feat(test): real prover tests use dummy input for keygen
jonathanpwang 469e991
chore: make `LoadedKeccakF` public
jonathanpwang 3179134
fix(keccak_leaf): review comments and optimization
jonathanpwang 695f80d
chore: use `gate` when `range` not necessary
jonathanpwang be35b58
Move calculate base ciruit params out & Fix naming/comments
nyunyunyunyu 87dd1fc
Make Field-related parameter functions const
nyunyunyunyu 492712d
feat: change `is_final` to `SafeBool`
jonathanpwang 33bfd9f
nit
jonathanpwang 5c803b8
Fix typo
nyunyunyunyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pse-poseidon
should only be in dev-dependencies, do not include in productionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encode
is currently only used for testing, so this is ok. but maybe later I'll change encode to a feature that enables snark-verifier import