Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement schnorr siganture #116

Merged

Conversation

odyssey2077
Copy link
Contributor

No description provided.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

halo2-ecc/src/ecc/schnorr_signature.rs Show resolved Hide resolved
halo2-ecc/src/fields/fp.rs Show resolved Hide resolved
halo2-ecc/src/bigint/big_is_even.rs Outdated Show resolved Hide resolved
halo2-ecc/src/bigint/big_is_even.rs Outdated Show resolved Hide resolved
@jonathanpwang jonathanpwang enabled auto-merge (squash) August 26, 2023 00:10
auto-merge was automatically disabled August 28, 2023 23:01

Head branch was pushed to by a user without write access

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more nits

halo2-ecc/src/bigint/big_is_even.rs Outdated Show resolved Hide resolved
halo2-ecc/src/ecc/schnorr_signature.rs Outdated Show resolved Hide resolved
halo2-ecc/src/bigint/big_is_even.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit 5de49cf into axiom-crypto:community-edition Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants