Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added refresh token to acquireMSAuth #123

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

GaMeNu
Copy link

@GaMeNu GaMeNu commented Sep 16, 2024

Gave the MSUtils class the ability to store a Microsoft refresh token. This should fix Issue #122, by using the refresh token to refresh the session after invalidation.

The MSUtils class will now grab the refresh token from the access token JSON, and store it in a static var. After the next login, it will use the refresh token instead of asking for authorization again.

@GaMeNu GaMeNu changed the title Added refresh token to acquire MSAuth Added refresh token to acquireMSAuth Sep 16, 2024
@GaMeNu GaMeNu requested a review from axieum September 29, 2024 12:37
@axieum
Copy link
Owner

axieum commented Oct 3, 2024

Hi @GaMeNu 👋

It's been a couple weeks now. I assume you have been using your build of the mod for a while. Has this change fixed your issue?

Thanks,

@GaMeNu
Copy link
Author

GaMeNu commented Oct 15, 2024

Hey, sorry for the late reply.
The new build seems to work fine after the first log-in using the mod (don't know how to fix for before first log in, since the mod can't get a refresh nor an access token beforehand atm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants