Add export command to dem #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosmurai
requested changes
Aug 1, 2023
tests/cli/test_export_cmd.py
Outdated
There was a problem hiding this comment.
Please try to achieve 100% code coverage: test cases are missing for the execute() function. The execute() function should be tested through the CLI runner (for example: runner.invoke(main.typer_cli, ["export", "Cica", "home"])
dem/cli/command/export_cmd.py
Outdated
| from dem.cli.console import stderr | ||
| import json, os | ||
|
|
||
| def check_is_file(param): |
There was a problem hiding this comment.
This function is not used.
dem/cli/command/export_cmd.py
Outdated
| def check_is_directory(param): | ||
| return(os.path.isdir(param)) | ||
|
|
||
| def create_exported_dev_env_json(dev_env_name,dev_env_json,given_path): |
There was a problem hiding this comment.
Please add type annotations for both the params and the return value.
dem/cli/main.py
Outdated
| @@ -62,6 +62,14 @@ def create(dev_env_name: str = typer.Argument(..., | |||
| """ | |||
| create_cmd.execute(dev_env_name) | |||
|
|
|||
| @typer_cli.command() | |||
| def export(dev_env_name: str = typer.Argument(...,help="Name of the Development Environment to export."), | |||
| path_to_export: str = typer.Argument(...,help="Path where to extract the Dev Env.")) -> None: | |||
There was a problem hiding this comment.
Make the path_to_export option optional: typer.Argument(None, help=""). This scenario needs to be handled in the create_exported_dev_env_json().
janosmurai
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.